-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modules rewrite, storage refactor, huge clenup #3230
Modules rewrite, storage refactor, huge clenup #3230
Conversation
Issue-3152. Modules rewrite to match new design.
Feature/3152 modules 2.0 rewrite
@filrak please remember to add the upgrade notes with these collection name changes |
…vue-storefront into modules-storage-refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work guys!
Just few suggestions from me. With localized
word just for consistency :)
Co-Authored-By: Patryk Tomczyk <13100280+patzick@users.noreply.github.com>
Co-Authored-By: Patryk Tomczyk <13100280+patzick@users.noreply.github.com>
Co-Authored-By: Patryk Tomczyk <13100280+patzick@users.noreply.github.com>
Co-Authored-By: Patryk Tomczyk <13100280+patzick@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this little one in :)
…vue-storefront into modules-storage-refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Filip for changes, everything's great! :)
CI also passed, so i merge that"little one" in ;P
Great job! |
Continuation of #3144
Short description and why it's useful
get
fallback. Now cache/module/StorageManager/config keys are identical for all of the entities which should end up in easier debugging ;):syncTaskCollection
renamed tosyncTasks
compareCollection
renamed tocompare
cmsData
renamed to cmscartsCollection
renamed to cartscheckoutFieldValues
,checkoutFieldsCollection
renamed tocheckout
(there was different getter and setter for same entity, one was fully redundant)initCacheStorage.ts
tocache.ts
, add webpack alias for backward compatibilityMore code was deleted than added so it's a good one ^^
TODO in the next iteration
core/lib
and rename toCacheManager